settings: persist generation defaults and player mute state#58
Open
LiBai (RGB-loop) wants to merge 1 commit intoLightricks:mainfrom
Open
settings: persist generation defaults and player mute state#58LiBai (RGB-loop) wants to merge 1 commit intoLightricks:mainfrom
LiBai (RGB-loop) wants to merge 1 commit intoLightricks:mainfrom
Conversation
Extend AppSettings to remember user's preferred generation parameters (model, duration, resolution, fps, aspect ratio, camera motion) and video player mute state across app restarts. Previously these settings were hardcoded defaults that reset on every launch, causing users to repeatedly adjust their preferences. Backend: - Add 7 new fields to AppSettings and SettingsResponse - Add validators for duration and fps clamping Frontend: - Initialize Playground/GenSpace settings from appSettings - Sync user changes back to backend via updateSettings - VideoPlayer now reads/writes playerMuted from appSettings Closes Lightricks#29 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppSettingsto persist user's preferred generation parameters (model, duration, resolution, fps, aspect ratio, camera motion) and video player mute state across app restartsChanges
Backend (
backend/state/app_settings.py):default_model,default_duration,default_video_resolution,default_fps,default_aspect_ratio,default_camera_motion,player_mutedSettingsResponsewith matching fieldsFrontend:
AppSettingsContext.tsx: Extend interface and defaultsPlayground.tsx/GenSpace.tsx: Initialize fromappSettings, sync changes viaupdateSettingsVideoPlayer.tsx: Read/writeplayerMutedfromappSettingsTest plan
Closes #29